Skip to content

test: add cmd format/encoding unit tests, update e2e tests #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
idunbarh merged 7 commits into from
Oct 16, 2024
Merged

test: add cmd format/encoding unit tests, update e2e tests #185

idunbarh merged 7 commits into from
Oct 16, 2024

Conversation

@ashearin
Copy link
Member

@ashearin ashearin commented Oct 9, 2024 •
edited
Loading

Description

Adds unit tests and fixes for format/encoding helper functions in cmd/export.go. Added additional e2e tests to cover items not easily tested via unit tests.

Fixes #177

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Additional e2e tests
  • Unit tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ashearin ashearin self-assigned this Oct 9, 2024
@ashearin ashearin requested a review from a team as a code owner October 9, 2024 00:34
@ashearin ashearin changed the title test: add cmd format/encoding unit tests, update e2e tests to increase coverage tests: add cmd format/encoding unit tests, update e2e tests to increase coverage Oct 9, 2024
@ashearin ashearin changed the title tests: add cmd format/encoding unit tests, update e2e tests to increase coverage test: add cmd format/encoding unit tests, update e2e tests Oct 9, 2024
jhoward-lm
jhoward-lm reviewed Oct 9, 2024
View reviewed changes
@ashearin ashearin requested a review from jhoward-lm October 14, 2024 15:09
@idunbarh idunbarh requested review from a team, eddiezane, idunbarh, lmphil and mfrystacky October 16, 2024 14:36
jhoward-lm
jhoward-lm approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@jhoward-lm jhoward-lm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@idunbarh idunbarh merged commit c703ea3 into bomctl:main Oct 16, 2024
@ashearin ashearin deleted the 177-units-tests-for-cmd-folder-functionality branch October 17, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@idunbarh idunbarh idunbarh approved these changes

@jhoward-lm jhoward-lm jhoward-lm approved these changes

@eddiezane eddiezane Awaiting requested review from eddiezane

@lmphil lmphil Awaiting requested review from lmphil

@mfrystacky mfrystacky Awaiting requested review from mfrystacky

Assignees

@ashearin ashearin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Units tests for 'cmd' folder functionality

3 participants

@ashearin @idunbarh @jhoward-lm