test: add unit tests for alias/tags DB functions #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
jhoward-lm
requested changes
Oct 1, 2024
Contributor
|
PR title must be conventional commit and should use standard casing. e.g. |
jhoward-lm
previously requested changes
Oct 1, 2024
Contributor
|
Can you try updating func (backend *Backend) FilterDocumentsByTag(documents []*sbom.Document, tags ...string) ([]*sbom.Document, error) {
taggedDocuments, err := backend.GetDocumentsByAnnotation(TagAnnotation, tags...)
if err != nil {
return nil, fmt.Errorf("failed to get documents by tag: %w", err)
}
taggedDocumentIDs := sliceutil.Extract(taggedDocuments, func(doc *sbom.Document) string {
return doc.GetMetadata().GetId()
})
documents = sliceutil.Filter(documents, func(doc *sbom.Document) bool {
return slices.Contains(taggedDocumentIDs, doc.GetMetadata().GetId())
})
return documents, nil
} |
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
…mctl/bomctl into alias-unit-tests Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
Signed-off-by: Philippe <philippe.a.aviles@lmco.com>
ashearin
approved these changes
Oct 2, 2024
idunbarh
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is meant to add unit tests to DB functions related to the "alias" and "tags" features.
Type of change
How Has This Been Tested?
Checklist