test: integration testing of functionality #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idunbarh
reviewed
Sep 24, 2024
7cf0605 to
8470f22
Compare
09a753b to
cf43a8e
Compare
idunbarh
approved these changes
Oct 2, 2024
Member
idunbarh
left a comment
There was a problem hiding this comment.
Wow! This is a really great addition to the project. Thanks for putting this together!
cf43a8e to
f82991f
Compare
lmphil
approved these changes
Oct 2, 2024
ashearin
commented
Oct 2, 2024
Contributor
|
For the revive - name: confusing-naming
exclude: [TEST]Unless you'd prefer to just rename the method in |
b59dcbc to
5078ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding e2e tests using testscript package.
There are commented out tests/lines in different files for failures that weren't expected and were not a quick fix. I attempted to record the failure reason, so if you have more context on a failure or know how to fix the issue please lmk. Otherwise a follow on issue will be created for each.
Also made an update to the way the root cmd is called, as it was needed for this test package.
These tests can be run as part of the general 'go test' cmd, but I added tasks in the task file and Makefile to run only the e2e and unit tests.
Fixes #121
References (More info on testscript)