Skip to content

Conversation

@jhoward-lm
Copy link
Contributor

Description

This PR updates the Client interface to allow push operations to:

  • Prepare a "staging area" for the full SBOM external reference graph
  • Recursively add all externally referenced SBOMs to this staging area
  • Do a single push operation containing all staged SBOMs

It also updates the existing Git push operation to use this pattern.

Depends on #153 being merged first (comparison of changes)

Fixes #154

Type of change

  • Refactor/enhancement

How Has This Been Tested?

  • Stand up temporary Git server for testing push, pull, and clone

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
…s at once

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm added the enhancement New feature or request label Sep 13, 2024
@jhoward-lm jhoward-lm self-assigned this Sep 13, 2024
@jhoward-lm jhoward-lm requested a review from a team as a code owner September 13, 2024 20:42
@jhoward-lm jhoward-lm linked an issue Sep 13, 2024 that may be closed by this pull request
…omctl into 154-client-prepare-push

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
…nt-prepare-push

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm merged commit 40130aa into main Sep 19, 2024
@jhoward-lm jhoward-lm deleted the 154-client-prepare-push branch September 19, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Stage all externally referenced SBOMs before push

5 participants