-
Notifications
You must be signed in to change notification settings - Fork 19
docs: Add Bomctl chart document to the repo #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: riaan kleinhans <riaankleinhans@gmail.com>
Signed-off-by: riaan kleinhans <riaankleinhans@gmail.com>
Signed-off-by: riaan kleinhans <riaankleinhans@gmail.com>
|
Hi @riaankleinhans, thanks for the PR! Do you mind updating the title of the PR to something like |
Signed-off-by: riaan kleinhans <riaankleinhans@gmail.com>
Signed-off-by: riaan kleinhans <riaankleinhans@gmail.com>
|
@jhoward-lm you are quick! Fixed the nits. |
|
@riaankleinhans one other thing, your commits appear to be unverified, so I don't believe it will let us merge this PR until it's resolved. You may need to add the GPG/SSH key that was used to your GitHub profile, or configure your local git client to sign the commits. If the local git client is the issue, you may need to re-write the history and re-push the commit. Once the client is configured with commit signing, I'd recommend something like this to reset your branch's head back to main but keep your changes, then re-commit with a new squashed commit of your changes, then push again. git reset --mixed origin/main
git add docs/charter.md
git commit --signoff --message="add charter document"
git push --force-with-leaseSorry if the commands are incorrect, I don't use the git CLI directly all that much, but that's the general idea 😄 One other tiny nit but I won't hold up the PR for it, and it's my fault for providing bad info in the first place, but I think this **Adopted August 5, 2024** <!-- markdownlint-disable-line -->would be preferable instead of the global |
Signed-off-by: riaan kleinhans <riaankleinhans@gmail.com>
|
I recreated this PR as #146 with the same content but with a signed commit to pass checks. I'm going to close this PR. |
Description
Adding the charter document to the repo
Type of change