Skip to content

Conversation

@riaankleinhans
Copy link

@riaankleinhans riaankleinhans commented Aug 30, 2024

Description

Adding the charter document to the repo

Type of change

  • This change is a documentation update

Signed-off-by: riaan kleinhans <riaankleinhans@gmail.com>
Signed-off-by: riaan kleinhans <riaankleinhans@gmail.com>
Signed-off-by: riaan kleinhans <riaankleinhans@gmail.com>
@riaankleinhans riaankleinhans requested a review from a team as a code owner August 30, 2024 16:37
@riaankleinhans riaankleinhans changed the title Add Bomclt chart document to the repo Add Bomctl chart document to the repo Aug 30, 2024
@jhoward-lm
Copy link
Contributor

Hi @riaankleinhans, thanks for the PR! Do you mind updating the title of the PR to something like docs: bomctl charter (as long as it starts with docs: and fixes the Bomclt typo). Thanks!

Signed-off-by: riaan kleinhans <riaankleinhans@gmail.com>
Signed-off-by: riaan kleinhans <riaankleinhans@gmail.com>
@riaankleinhans riaankleinhans changed the title Add Bomctl chart document to the repo docs: Add Bomctl chart document to the repo Aug 30, 2024
@riaankleinhans
Copy link
Author

@jhoward-lm you are quick! Fixed the nits.

@jhoward-lm
Copy link
Contributor

jhoward-lm commented Aug 30, 2024

@riaankleinhans one other thing, your commits appear to be unverified, so I don't believe it will let us merge this PR until it's resolved. You may need to add the GPG/SSH key that was used to your GitHub profile, or configure your local git client to sign the commits.

If the local git client is the issue, you may need to re-write the history and re-push the commit. Once the client is configured with commit signing, I'd recommend something like this to reset your branch's head back to main but keep your changes, then re-commit with a new squashed commit of your changes, then push again.

git reset --mixed origin/main
git add docs/charter.md
git commit --signoff --message="add charter document"
git push --force-with-lease

Sorry if the commands are incorrect, I don't use the git CLI directly all that much, but that's the general idea 😄

One other tiny nit but I won't hold up the PR for it, and it's my fault for providing bad info in the first place, but I think this

**Adopted August 5, 2024** <!-- markdownlint-disable-line -->

would be preferable instead of the global <!-- markdownlint-disable --> I originally suggested

Signed-off-by: riaan kleinhans <riaankleinhans@gmail.com>
@idunbarh
Copy link
Member

idunbarh commented Sep 1, 2024

I recreated this PR as #146 with the same content but with a signed commit to pass checks. I'm going to close this PR.

@idunbarh idunbarh closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants