Skip to content

feat: bomctl push subcommand OCI client functionality #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhoward-lm merged 15 commits into from
Sep 20, 2024
Merged

feat: bomctl push subcommand OCI client functionality #139

jhoward-lm merged 15 commits into from
Sep 20, 2024

Conversation

@jhoward-lm
Copy link
Contributor

@jhoward-lm jhoward-lm commented Aug 22, 2024

Description

This PR implements support for OCI URLs in bomctl push.

Fixes #123

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jhoward-lm jhoward-lm added the enhancement New feature or request label Aug 22, 2024
@jhoward-lm jhoward-lm self-assigned this Aug 22, 2024
@idunbarh
Copy link
Member

idunbarh commented Sep 4, 2024

Please update the README.md that includes the command instructions.

@jhoward-lm jhoward-lm marked this pull request as ready for review September 4, 2024 19:29
@jhoward-lm jhoward-lm requested a review from a team as a code owner September 4, 2024 19:29
@jhoward-lm
Copy link
Contributor Author

jhoward-lm commented Sep 4, 2024

Please update the README.md that includes the command instructions.

done!

@jhoward-lm
feat: document annotations for source data, hash, format, and URL
48e390f 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
fix: set Git config for push test
ea5f020 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
refactor: add client interface methods to allow pushing multiple file…
973569a 
…s at once

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
test: add httptest Git server for testing remote Git operations
da82eff 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
Merge branch 'main' of https://github.com/bomctl/bomctl into 68-exten…
db48f7f 
…ded-ent-schemas
@jhoward-lm
Merge branch '68-extended-ent-schemas' of https://github.com/bomctl/b…
d4e4dd3 
…omctl into 154-client-prepare-push

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
Merge branch 'main' of https://github.com/bomctl/bomctl into 154-clie…
0051abf 
…nt-prepare-push

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
refactor: push multiple files as single OCI artifact archive
cc4a61f 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
Merge branch 'main' of https://github.com/bomctl/bomctl into 154-clie…
da21075 
…nt-prepare-push
@jhoward-lm
refactor: scoped test suites
9ce506e 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
Merge branch '154-client-prepare-push' of https://github.com/bomctl/b…
c1e7f2d 
…omctl into push-oci

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
test: OCI client AddFile test
4bfc7af 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
Merge branch 'main' of https://github.com/bomctl/bomctl into push-oci
41977ff 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
test: OCI client Push test
fbe43d1 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
Merge branch 'main' of https://github.com/bomctl/bomctl into push-oci
7fddf10
@jhoward-lm jhoward-lm merged commit 157d6de into main Sep 20, 2024
@jhoward-lm jhoward-lm deleted the push-oci branch September 20, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashearin ashearin ashearin approved these changes

@idunbarh idunbarh idunbarh approved these changes

@lmphil lmphil lmphil approved these changes

@eddiezane eddiezane Awaiting requested review from eddiezane

@mfrystacky mfrystacky Awaiting requested review from mfrystacky

Assignees

@jhoward-lm jhoward-lm

Labels

enhancement New feature or request

Projects

bomctl
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Push Subcommand: OCI client functionality

5 participants

@jhoward-lm @idunbarh @ashearin @lmphil