Skip to content

Conversation

@ashearin
Copy link
Member

Pull Request Template

Description

Contains a number of changes/improvements:

  • Updates to push subcmd to only allow one sbomID at a time (at least for now)
  • Adds format handling in push subcmd
  • Adds Make directive to fix linting errors if possible
  • Moves cmd options into options file, out of client.go
  • Improvement to getBackend to consolidate repeated code into the function itself
  • Removes fetcher/Pusher interfaces in favor of consolidated client interface
  • Updates to Fetch/Push Function definitions
  • Naming Changes to reflect recent refactoring
  • Pushed url parsing into client files
  • Pushed Auth handling into client files, standardized auth handling

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ashearin ashearin self-assigned this Aug 15, 2024
@ashearin ashearin requested a review from a team as a code owner August 15, 2024 04:03
@jhoward-lm
Copy link
Contributor

jhoward-lm commented Aug 15, 2024

Can we update the title in the description to something other than Pull Request Template, or just remove that H1 altogether? We can update the PR template to remove the H1 heading if it doesn't add much value

@idunbarh idunbarh merged commit 5722dfd into main Aug 15, 2024
@idunbarh idunbarh deleted the client-refinement branch August 15, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants