Skip to content

Conversation

@jhoward-lm
Copy link
Contributor

Add client package shared by fetch and push commands

Description

This PR adds a Client interface that embeds both Fetcher and Pusher. It also restructures the project to reduce code duplication.

Type of change

  • Refactor

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm added the enhancement New feature or request label Aug 8, 2024
@jhoward-lm jhoward-lm self-assigned this Aug 8, 2024
@jhoward-lm jhoward-lm requested a review from a team as a code owner August 8, 2024 21:27
Copy link
Member

@ashearin ashearin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@idunbarh idunbarh merged commit 30ed29a into main Aug 12, 2024
@idunbarh idunbarh deleted the client-package branch August 12, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants