Conversation
🦋 Changeset detectedLatest commit: 0cf0e1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@example/basic • @example/changesets commit: |
There was a problem hiding this comment.
I'm definitely in favor of anything that makes theming easier! Always hoped people would use @clack/core to create their own branded experiences, but that package is still a bit too low-level...
Maybe we should consider adding a theme to the global ClackSettings that could be a hook for global stylistic changes like this? Seems a bit frustrating to require passing withBorder: false every time.
|
the global settings have their downsides too, since you may not always want to every prompt to follow these rules maybe in a follow up change, we can make the global settings inherit some of the shared settings, and the inline option takes precedence. i.e. if you set global |
|
i've renamed this to @delucis could you take another look? |
|
ok @natemoo-re i've added a global i'll aim to merge this today so let me know if any of you have any feedback |
This adds a new
withGuideoption which decides if the standard clack left border is rendered or not.Not all prompts implement this yet. We can add support for more prompts over time.