fix(note,box): handle cjk correctly#391
Merged
43081j merged 11 commits intobombshell-dev:mainfrom Sep 8, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 7634791 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@example/basic • @example/changesets commit: |
43081j
reviewed
Sep 7, 2025
Contributor
Author
|
@43081j, do we need to add tests? |
43081j
approved these changes
Sep 8, 2025
Collaborator
|
we should add a test for each of the two prompts that basically contains a wide character i think e.g. it could set the max columns to 10 or something, and output 5 or 6 wide chars to prove it goes across 2 lines |
43081j
reviewed
Sep 8, 2025
Contributor
Author
|
@43081j, can you merge this? |
43081j
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115