feat: add param to clear input after password prompt error#364
Merged
43081j merged 4 commits intobombshell-dev:mainfrom Aug 11, 2025
Merged
feat: add param to clear input after password prompt error#36443081j merged 4 commits intobombshell-dev:mainfrom
43081j merged 4 commits intobombshell-dev:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 040266b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
43081j
reviewed
Aug 7, 2025
43081j
reviewed
Aug 7, 2025
43081j
reviewed
Aug 7, 2025
Collaborator
|
im thinking it may make more sense to call it if a prompt has a default value, i'd expect |
|
@example/basic • @example/changesets commit: |
43081j
approved these changes
Aug 11, 2025
43081j
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
clearOnErroroption to the password prompt to enforce typing the whole password again on an error. This is particularly useful whenmask: ''(i.e. a hidden input) is given.e.g. Consider this case
If the user enters "password" and hits return, an (expected) error

Password must be "test123"will appear, like so:The user then enters "test123" and hits return. They will get the same error because the value is actually "passwordtest123" which is not apparent with a hidden input.
This PR adds a
clearOnErrorboolean option to have the input clear out after an error to avoid the confusion above.