fix(prompts): Fix dots loader in spinner#309
Merged
43081j merged 1 commit intobombshell-dev:mainfrom Apr 29, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 2cfe142 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@example/basic • @example/changesets commit: |
43081j
requested changes
Apr 29, 2025
Collaborator
43081j
left a comment
There was a problem hiding this comment.
makes sense to me
can you add a changeset?
47c6664 to
2cfe142
Compare
Contributor
Author
Added ! |
43081j
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the dots indicator (the ellipsis) were linked to the symbols used, 4 char (
◒,◐,◓,◑)The timing of the dots was one dot every 8 frame (+0.125 every frame, so a integer number every 8 frame) which was OK since we display 3 dots.
But now that the spinner frame char can be changed, this logic don't work anymore.
For example, if you have 10 spinner frames you will have (excluding non-integer number):
And if you have only 2 spinner frames :
This PR fix this by basing the dots indicator only on itself