Skip to content

Add stacked lines and directed areas#8873

Merged
bryevdv merged 1 commit intomasterfrom
byanv/8848_stacked_lines_areas
Apr 29, 2019
Merged

Add stacked lines and directed areas#8873
bryevdv merged 1 commit intomasterfrom
byanv/8848_stacked_lines_areas

Conversation

@bryevdv
Copy link
Copy Markdown
Member

@bryevdv bryevdv commented Apr 29, 2019

@mattpap @birdsarah I plan to merge this when green so that the hatching PR can be rebased on top (to add hatching support for these new glyphs as well). I'll add narrative documentation in a follow-on PR later this week.

But please make comments, corrections, or suggestions here. I will make changes in one of the other PRs.

@bryevdv
Copy link
Copy Markdown
Member Author

bryevdv commented Apr 29, 2019

@birdsarah particularly interested what you think of line_stack API. Currently have

line_stack(x, y, **kw)

which expects one of x or y to be sequence to "stack", but not both (will error if both are). Alternatively could do

line_stack(stackers, **kw)

which would explicitly have one arg for the stackers, and whether it is x or y depends on the the other one being provided as a kw arg, e.g line_stack([...], x=...) will stack y coords, because x= was provided.

Other option is to explicitly have hline_stack and vline_stack but that's getting a but verbose even for me.

@bryevdv bryevdv force-pushed the byanv/8848_stacked_lines_areas branch from f7eb58e to 77a8b9c Compare April 29, 2019 00:30
@bryevdv bryevdv merged commit 9611f34 into master Apr 29, 2019
@bryevdv bryevdv deleted the byanv/8848_stacked_lines_areas branch April 29, 2019 01:00
@birdsarah
Copy link
Copy Markdown
Member

Sorry I didn't see your message in time. Here's my thoughts anyway.....don't hate me....but I actually like hline_stack, vline_stack. My reasoning is that it is in keeping with an existing mental model for hbar, vbar, harea, varea... I think it's good to follow patterns whenever they're available. My take is that verbose is annoying, but not as annoying as having to look up syntax.

@bryevdv
Copy link
Copy Markdown
Member Author

bryevdv commented May 18, 2019

FYI I have a WIP branch that makes that change

@birdsarah
Copy link
Copy Markdown
Member

birdsarah commented May 18, 2019 via email

@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Stacked Areas and Lines

2 participants