Conversation
|
@birdsarah particularly interested what you think of which expects one of x or y to be sequence to "stack", but not both (will error if both are). Alternatively could do which would explicitly have one arg for the stackers, and whether it is x or y depends on the the other one being provided as a kw arg, e.g Other option is to explicitly have |
f7eb58e to
77a8b9c
Compare
|
Sorry I didn't see your message in time. Here's my thoughts anyway.....don't hate me....but I actually like hline_stack, vline_stack. My reasoning is that it is in keeping with an existing mental model for hbar, vbar, harea, varea... I think it's good to follow patterns whenever they're available. My take is that verbose is annoying, but not as annoying as having to look up syntax. |
|
FYI I have a WIP branch that makes that change |
|
Sweet!
… On May 18, 2019, at 6:03 PM, Bryan Van de Ven ***@***.***> wrote:
FYI I have a WIP branch that makes that change
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
@mattpap @birdsarah I plan to merge this when green so that the hatching PR can be rebased on top (to add hatching support for these new glyphs as well). I'll add narrative documentation in a follow-on PR later this week.
But please make comments, corrections, or suggestions here. I will make changes in one of the other PRs.