Skip to content

Added docstrings on app\examples#11872

Merged
bryevdv merged 1 commit intobokeh:branch-3.0from
ArchaeotheriumSapienter:Docstring-app-examples
Dec 16, 2021
Merged

Added docstrings on app\examples#11872
bryevdv merged 1 commit intobokeh:branch-3.0from
ArchaeotheriumSapienter:Docstring-app-examples

Conversation

@ArchaeotheriumSapienter
Copy link
Copy Markdown
Contributor

@ArchaeotheriumSapienter ArchaeotheriumSapienter commented Dec 8, 2021

Added docstrings on app\examples to tackle #11540 with additional note blocks in some of the files.

@ArchaeotheriumSapienter ArchaeotheriumSapienter changed the title Added docstrings to app\examples Added docstrings on app\examples Dec 8, 2021
@bryevdv
Copy link
Copy Markdown
Member

bryevdv commented Dec 8, 2021

Thanks @ArchaeotheriumSapienter just a few final suggestions concerning Sphinx link alias (please push new changes to this same branch)

@ArchaeotheriumSapienter
Copy link
Copy Markdown
Contributor Author

I'm done with the changes in this Pull Request, thank you so much!

Copy link
Copy Markdown
Member

@bryevdv bryevdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comments:

  • one unused alias
  • edits to use consistent verbiage (always good to be consistent this way, to help situate users)

@bryevdv
Copy link
Copy Markdown
Member

bryevdv commented Dec 14, 2021

FYI if you go the files tab, you can apply suggestions in a batch from the web UI (if you want to use that method)

@ArchaeotheriumSapienter
Copy link
Copy Markdown
Contributor Author

Thank you for the input! I'll keep those in mind next time :)

with the distribution option.

.. note::
This chart needs the Scipy and Pandas package to run. See
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I guess I missed one last one, will be good to merge after this:

Suggested change
This chart needs the Scipy and Pandas package to run. See
This example needs the Scipy and Pandas package to run. See

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Its also on my part since I was not consistent, I'll keep your suggestions in mind next time :)

@bryevdv
Copy link
Copy Markdown
Member

bryevdv commented Dec 16, 2021

Thanks @ArchaeotheriumSapienter !

@ArchaeotheriumSapienter
Copy link
Copy Markdown
Contributor Author

Thank you!

@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants