Miscellaneous refactorings in bokehjs#10450
Merged
mattpap merged 8 commits intobranch-2.3from Aug 31, 2020
Merged
Conversation
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most changes should be self evident (one commit per change class). One thing that needs some explanation is making
Ticker<T>non-generic. This has been an artifact from early transition period to TypeScript. Retrospectively treating models as generic was an obviously wrong choice, and the information about types (primarilynumberfor continuous case andFactorfor categorical) is now embedded within the class structure in various ways (this will have to be unified at some point across relevant models).