Migrate property definitions to use kinds#10433
Merged
mattpap merged 16 commits intobranch-2.3from Aug 31, 2020
Merged
Conversation
5a62d7c to
2bca598
Compare
2bca598 to
12690f6
Compare
12690f6 to
38505f9
Compare
38505f9 to
d45327f
Compare
1205b21 to
1a55f2e
Compare
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates (almost) all primitive (non-specs) properties to the new system. I will take care of specs and the remaining TODOs in another PR. This also makes nullable properties strictly checked in bokehjs (finally!). I fixed a bunch of inconsistencies between bokeh and bokehjs and, internal to bokehjs, that were revealed by this work. The cost of change is surprisingly small and adds about ~2kB to the main bundle. This increase may actually be at least partially reverted in future, because I'm considering to not specify intrinsic defaults explicitly (e.g.
[]for array type) in future.