Updating RcppArmadillo initialization#1
Merged
boennecd merged 1 commit intoboennecd:masterfrom Sep 9, 2022
Merged
Conversation
These changes update RcppArmadillo from the now deprecated `<<` initialization to brace initialization allowed since C++11 and long been the minimal standard with R too. It would be great if you could merge this, and release and updated package "in the next little while" -- see the two prior emails I sent, and the transition log at RcppCore/RcppArmadillo#391
Closed
31 tasks
Owner
|
Excellent, thank you! I have also fixed pedmod (see boennecd/pedmod@f8740ec).
I think this will do https://github.com/boennecd/pedmod/blob/f8740eccec94585df88b9f5fc2027117bcea5ce4/src/arma-wrap.h#L15-L18 I will have to change this in some other packages as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes update RcppArmadillo from the now deprecated
<<initialization to brace initialization allowed since C++11 and long been the minimal standard with R too. It would be great if you could merge this, and release and updated package "in the next little while" -- see the two prior emails I sent, and the transition log at RcppCore/RcppArmadillo#391(There is another
#pragma deprecatedwarning about error printing you probably need to take care of too. Let me know if you want to look at that too.)