Skip to content

Html coop parsing#12

Closed
jugglinmike wants to merge 3 commits intomaster-coop-coepfrom
html-coop-parsing
Closed

Html coop parsing#12
jugglinmike wants to merge 3 commits intomaster-coop-coepfrom
html-coop-parsing

Conversation

@jugglinmike
Copy link
Member

No description provided.

@jugglinmike jugglinmike requested a review from zcorpan December 18, 2019 21:19
@jugglinmike
Copy link
Member Author

Use same-origin instead of same-site since the latter should not be
supported.

(via web-platform-tests@bb1376b#commitcomment-36480961)

Definitely

As far as I can tell, it's possible to get duplicated headers with a
.headers file. I think that is nicer than .asis.

(via web-platform-tests@bb1376b#commitcomment-36481209)

And I think .asis is nicer :) We won't be able to move forward without more
substantive rationale, so I'll start.

The benefit of an .asis file is that all relevant information is expressed in
one place. Using .headers means that readers need to open two files to
understand the intent of a given file, and that assumes they even know to look.

@zcorpan
Copy link

zcorpan commented Dec 19, 2019

.headers is more used in general, so people need to be aware of them anyway. Using .asis also means people need to learn how that works, too.

However, I think either is OK, so we should just submit this as-is (ahem) 😊

@jugglinmike
Copy link
Member Author

Cool. Here it is: web-platform-tests#20873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants