Throw RangeError when BigInt division by zero occurs#790
Merged
HalidOdat merged 7 commits intoboa-dev:masterfrom Oct 4, 2020
Merged
Throw RangeError when BigInt division by zero occurs#790HalidOdat merged 7 commits intoboa-dev:masterfrom
HalidOdat merged 7 commits intoboa-dev:masterfrom
Conversation
JohnDoneth
commented
Oct 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #790 +/- ##
==========================================
- Coverage 59.28% 59.13% -0.16%
==========================================
Files 156 155 -1
Lines 9820 9842 +22
==========================================
- Hits 5822 5820 -2
- Misses 3998 4022 +24
Continue to review full report at Codecov.
|
HalidOdat
reviewed
Oct 4, 2020
Lan2u
approved these changes
Oct 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request closes #780.
It changes the following:
Adds a check when dividing by zero to throw a RangeError if y (the right-hand expression) is
0n.Spec: https://www.ecma-international.org/ecma-262/#sec-numeric-types-bigint-divide