Skip to content

Implement Error.isError#4114

Merged
raskad merged 1 commit intomainfrom
is-error
Jan 8, 2025
Merged

Implement Error.isError#4114
raskad merged 1 commit intomainfrom
is-error

Conversation

@jedel1043
Copy link
Copy Markdown
Member

@jedel1043 jedel1043 commented Jan 8, 2025

Implements the Error.isError proposal, and unifies Error with ErrorObject into a single Error type.

@jedel1043 jedel1043 added A-Enhancement New feature or request C-Builtins PRs and Issues related to builtins/intrinsics labels Jan 8, 2025
@jedel1043 jedel1043 added this to the next-release milestone Jan 8, 2025
@jedel1043 jedel1043 requested a review from a team January 8, 2025 06:41
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 8, 2025

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 44,995 45,007 +12
Ignored 1,740 1,728 -12
Failed 3,519 3,519 0
Panics 0 0 0
Conformance 89.54% 89.56% +0.02%
Fixed tests (12): 
test/built-ins/Error/isError/non-error-objects-other-realm.js (previously Ignored)
test/built-ins/Error/isError/name.js (previously Ignored)
test/built-ins/Error/isError/error-subclass.js (previously Ignored)
test/built-ins/Error/isError/errors.js (previously Ignored)
test/built-ins/Error/isError/symbols.js (previously Ignored)
test/built-ins/Error/isError/bigints.js (previously Ignored)
test/built-ins/Error/isError/primitives.js (previously Ignored)
test/built-ins/Error/isError/is-a-constructor.js (previously Ignored)
test/built-ins/Error/isError/prop-desc.js (previously Ignored)
test/built-ins/Error/isError/errors-other-realm.js (previously Ignored)
test/built-ins/Error/isError/non-error-objects.js (previously Ignored)
test/built-ins/Error/isError/fake-errors.js (previously Ignored)

@jedel1043 jedel1043 force-pushed the is-error branch 2 times, most recently from 008e4f5 to 2213874 Compare January 8, 2025 07:31
nekevss
nekevss approved these changes Jan 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nekevss nekevss requested a review from a team January 8, 2025 15:06
@raskad raskad added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit ce6cfa8 Jan 8, 2025
@raskad raskad deleted the is-error branch January 8, 2025 16:15
@jedel1043 jedel1043 mentioned this pull request Jan 9, 2025
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raskad raskad raskad approved these changes

@nekevss nekevss nekevss approved these changes

Assignees

No one assigned

Labels

A-Enhancement New feature or request C-Builtins PRs and Issues related to builtins/intrinsics

Projects

None yet

Milestone

v0.21.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jedel1043 @raskad @nekevss