Add a ProjectLauncher#getCommand for easier extension #6471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if one wants to extend a Project launcher it is required to completely reimplement the launch() method even if one only wants to add some argument to the commandline. Also things like returncode handling and reporting of results need to be implemented again. This now adds a new method ProjectLauncher#getCommand() that externalize the process of creating a commandline, this also allows to access the final commandline from the outside (e.g. to show it to the user). Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
Member
|
nice work. I nowadays always try to have either control (decides flow) or worker (calculates some value) methods, never mix them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if one wants to extend a Project launcher it is required to completely reimplement the launch() method even if one only wants to add some argument to the commandline. Also things like returncode handling and reporting of results need to be implemented again.
This now adds a new method
ProjectLauncher#getCommand()that externalize the process of creating a commandline, this also allows to access the final commandline from the outside (e.g. to show it to the user) or further customize it.