fix RunRequirements could not be saved #6449
Conversation
The problem was that before this fix the call to super.commit(onSave); has reset the dirty flag from true back to false, which was the reason why commitToModel(onSave); did not work, because it checks for dirty==true Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
|
I never tested a snapahot of bnd that was selfbuild. Could you help me how to test |
|
@stbischof I took the liberty to merge it to master, since the change was small. Snapshot should be available in a few minutes... e.g. 30m. Please test this. In case something broke, I can revert it.
a bit short on time atm. I think there is a description somewhere, but I have to admint, I cannot remember how exactly too. I usually checkout other PRs and have the bndtools dev environment setup. But this is probably not your situation, since you are more of a user. |
|
Found it: https://bndtools.org/development.html : "Importing Into Eclipse" But honestly, I need to try it myself too :) |
|
Currently snapahot is not deployed |
|
I believe it is. I just got it.
I think it is |
|
Works on m Maschine |
|
Thnk you a lot!!! |
Closes #6448
The problem was that before this fix the call to super.commit(onSave); has reset the dirty flag from true back to false, which was the reason why commitToModel(onSave); did not work, because it checks for dirty==true
@stbischof could you test the PR?