first draft of Effective tab for BndEditor #6406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
426c073 to
9c48429
Compare
18e94ee to
52ea878
Compare
Contributor
Author
|
@pkriens this is the current status of the "Effective" tab in the BndEditor 
Further TODOs could be:
Let me know when you want to take over for more magic :) |
Member
|
I might take a stab in the next 2 weeks when I am not allowed to sit in my office :-) |
ce00b37 to
a3623f7
Compare
Signed-off-by: Christoph Rueger <chrisrueger@gmail.com> add find text via CMD+F Signed-off-by: Christoph Rueger <chrisrueger@gmail.com> add Syntax highlighting via SourceViewer remove unnecessary code remove some code which came in from JarPrintPage.java Signed-off-by: Christoph Rueger <chrisrueger@gmail.com> fix resource bundle found in org.eclipse.ui.texteditor.EditorMessages.BUNDLE_FOR_CONSTRUCTED_KEYS which is unfortunatelly not accessible (private) Signed-off-by: Christoph Rueger <chrisrueger@gmail.com> add line numbers Signed-off-by: Christoph Rueger <chrisrueger@gmail.com> rename tab just "Effective" Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
Signed-off-by: Christoph Rueger <chrisrueger@gmail.com> remove file
Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
use resizable SashForm Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
and finally fix the scrolling issues by borrowing StackLayout from JARPrintPage.java Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
this gives more flexibility when working with the values since we just don't have strings only Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
42e19c5 to
6286697
Compare
Contributor
Author
Thanks. I have pushed some improvements. Hope that might be a good place to takeover.
|
added 4 commits
January 6, 2025 16:04
--- Signed-off-by: github-actions <github-actions@bndtools.org> Signed-off-by: github-actions <github-actions@bndtools.org>
All the different places where we set properties now mark their provenance. In the case of the original we mark the original propertiesFile, in case of includes we track the included file. For defaults we use the provenance as a comment --- Signed-off-by: github-actions <github-actions@bndtools.org> Signed-off-by: github-actions <github-actions@bndtools.org>
We now maintain a list of merge property keys in Constants. The BndEdit Model now try to see if a property is part of a merge header and use the proper converter/formatter. --- Signed-off-by: github-actions <github-actions@bndtools.org> Signed-off-by: github-actions <github-actions@bndtools.org>
--- Signed-off-by: github-actions <github-actions@bndtools.org> Signed-off-by: github-actions <github-actions@bndtools.org>
Contributor
Author
|
@pkriens thanks for your additions. Did a few simple tests. Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a first draft of an readonly "Effective Source view" of a Bnd Editor based on comment #6401 (comment)
This is a nice additional debugging tool, because it makes things visible to the human eye, which were previously hidden.
Comment about code: I reused some code of the JarEditor (JarPrintPage.java) and added search-dialog and syntax highlighting. Sorry if this is not state-of-the-art Eclipse JFace code.