workspace: Fixes to workspace lock write-upgrade detection #5371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use a queue since there will be more mutations than traversals. We only mark thread as holding read lock once it actually does. We only check for write upgrade when tryLock times out so we can potentially avoid traversing the queue. Tests are also added. Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a queue since there will be more mutations than traversals. We only mark thread as holding read lock once it actually does. We only check for write upgrade when tryLock times out so we can potentially avoid traversing the queue.
Tests are also added.