signing: Write META-INF signing resources immediately after manifest #5268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signing is only possible when using the standard manifest name. Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
JarInputStream requires the META-INF signing resources to come after the manifest and before any other resources. Otherwise, JarInputStream does not consider the jar to be properly signed. Later versions of Equinox now use JarInputStream to verify the jar signing replacing Equinox's custom verification code. So Bnd needs to properly generate signed jars to work with JarInputStream. We also define a standard pattern for the META-INF signing resources which is used by other classes that care. Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JarInputStream requires the META-INF signing resources to come
after the manifest and before any other resources. Otherwise,
JarInputStream does not consider the jar to be properly signed.
Later versions of Equinox now use JarInputStream to verify the
jar signing replacing Equinox's custom verification code. So Bnd
needs to properly generate signed jars to work with JarInputStream.
We also define a standard pattern for the META-INF signing resources
which is used by other classes that care.