Skip to content

feat: add reconnectLoop for mev validators#25

Merged
pythonberg1997 merged 4 commits intodevelopfrom
roshan/builder
Apr 29, 2024
Merged

feat: add reconnectLoop for mev validators#25
pythonberg1997 merged 4 commits intodevelopfrom
roshan/builder

Conversation

@pythonberg1997
Copy link
Copy Markdown

Description

This pr is to add reconnectLoop for mev validators

Rationale

To make the bidder reconnect to offline validators automatically.

Example

add an example CLI or API response...

Changes

Notable changes:

  • add reconnectLoop for mev validators

miner/bidder.go Outdated

for {
select {
case <-time.After(10 * time.Minute):
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use a ticker?

miner/bidder.go Outdated
select {
case <-time.After(10 * time.Minute):
for _, v := range b.config.Validators {
if b.registered(v.Address) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it is not unregister, I think no bother to registered again

@pythonberg1997 pythonberg1997 merged commit 647c903 into develop Apr 29, 2024
@irrun irrun deleted the roshan/builder branch June 11, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants