Conversation
Mercybudda
reviewed
Jun 10, 2022
unclezoro
reviewed
Jun 16, 2022
unclezoro
reviewed
Jun 16, 2022
unclezoro
reviewed
Jun 16, 2022
unclezoro
reviewed
Jun 16, 2022
unclezoro
reviewed
Jun 16, 2022
unclezoro
reviewed
Jun 16, 2022
unclezoro
reviewed
Jun 16, 2022
Contributor
|
Besides, can you evaluate how this feature impacts the tx index system? |
Contributor
Author
It has no effect. It has been fixed for the online problem (that is, the tx index error reported from ancient data after executing the pruneblock tool). The fix is to check whether the block range that needs to be indexed is in ancient before creating the index. If it is not, it will Adjust the boundaries of the block range. |
calmbeing
previously approved these changes
Jun 20, 2022
Mercybudda
previously approved these changes
Jun 20, 2022
keefel
previously approved these changes
Jun 21, 2022
j75689
previously approved these changes
Jun 24, 2022
Mercybudda
previously approved these changes
Jun 24, 2022
keefel
approved these changes
Jun 29, 2022
j75689
approved these changes
Jun 29, 2022
Mercybudda
approved these changes
Jun 29, 2022
unclezoro
approved these changes
Jun 29, 2022
This was referenced Jul 28, 2022
Merged
zzzckck
reviewed
Jul 8, 2024
| batch.Reset() | ||
|
|
||
| // Step into the future and delete and dangling side chains | ||
| if frozen > 0 { |
Collaborator
There was a problem hiding this comment.
this code is quite risky, it could even delete the whole chain, is the "dangling" was created with a bug, such as issue: #2529
Maybe we don't need it, as we have already deleted the "dangling" block from first to frozen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Block Data no longer transfer to AncientDB when delete from KVStore.
Save more os resources, disk space, disk bandwidth, cpu.
Rationale
Release more disk space, disk bandwidth resources.
Example
"./geth" start command add "--puneancient" parameter
Changes
Notable changes: