[R4R]fix deadlock on miner module when failed to commit trie#835
Merged
unclezoro merged 1 commit intobnb-chain:developfrom Apr 2, 2022
Merged
[R4R]fix deadlock on miner module when failed to commit trie#835unclezoro merged 1 commit intobnb-chain:developfrom
unclezoro merged 1 commit intobnb-chain:developfrom
Conversation
0358d90 to
9691a8e
Compare
worldisreal
approved these changes
Apr 2, 2022
forcodedancing
approved these changes
Apr 2, 2022
yutianwu
approved these changes
Apr 2, 2022
keefel
approved these changes
Apr 2, 2022
This was referenced Apr 8, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A possible deadlock when commit trie failed
Rationale
A node stuck and failed to import any blocks, the go routine profile is: routine.txt
Blocked in sending task to
taskschannel.The task itself will send response to
taskResults, ifCommitTriefailed,taskResultswill get two signal, while the size oftaskResultsislen(s.stateObjectsDirty), which will cause the routine blocked.Example
No
Changes
No