[R4R]disable diffsync when pipecommit is enabled#820
Merged
unclezoro merged 1 commit intobnb-chain:developfrom Mar 30, 2022
Merged
[R4R]disable diffsync when pipecommit is enabled#820unclezoro merged 1 commit intobnb-chain:developfrom
unclezoro merged 1 commit intobnb-chain:developfrom
Conversation
j75689
approved these changes
Mar 30, 2022
yutianwu
approved these changes
Mar 30, 2022
NashBC
approved these changes
Mar 30, 2022
keefel
approved these changes
Mar 30, 2022
This was referenced Apr 8, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is going to disable diffsync when pipecommit is enabled.
Rationale
After several rounds of performance improvement, it turns out the
diffsyncperformance is no better than a pipecommit enabled node. This PR is going to disable diffsync when pipecommit is enabled and leave the further enhancement to #819Example
No
Changes
No