Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces multi-arch Docker image builds by adding arm64 support to the CI/CD pipeline.
- Updated the Dockerfile to use Alpine 3.21 for the deployment stage.
- Enhanced the GitHub Actions workflow (.github/workflows/docker-release.yml) by implementing a matrix build for amd64 and arm64, updating action versions, and incorporating multi-arch tag and manifest creation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Dockerfile | Bumps the Alpine version from 3.17 to 3.21 to support the updated base. |
| .github/workflows/docker-release.yml | Adds new jobs and steps for multi-arch build, including arm64 support, and updates various action versions. |
Comments suppressed due to low confidence (2)
Dockerfile:23
- Ensure that the Alpine version bump to 3.21 is compatible with all dependent libraries and any assumptions made in the rest of the build process.
+FROM alpine:3.21
.github/workflows/docker-release.yml:110
- [nitpick] Verify that using '*' for digest file expansion in the subsequent command only includes the intended files, to avoid accidental inclusion of unintended file names.
docker buildx imagetools create $(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON") \
c16865e to
669b6c2
Compare
buddh0
previously approved these changes
Jun 6, 2025
NathanBSC
reviewed
Jun 6, 2025
NathanBSC
reviewed
Jun 6, 2025
669b6c2 to
e0addd7
Compare
buddh0
approved these changes
Jun 10, 2025
zzzckck
approved these changes
Jun 10, 2025
Collaborator
|
@voron thank you for your contribution👍 |
This was referenced Jun 16, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds multi-arch docker image build using native arm64 GH runner. Based on Docker docs
Rationale
All 3 major cloud providers are selling arm64 cost-effective CPUs. It may be useful to Apple Silicon users as well
Changes
Notable changes: