Optimize Transaction Pool Gas Tip Comparison#3120
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the EffectiveGasTipCmp function in transaction.go to remove an unnecessary allocation by inlining the gas tip comparison logic.
- Removed reliance on EffectiveGasTipValue to avoid extra allocation.
- Introduced manual subtraction and minimum value comparisons for gas fee and gas tip caps.
Comments suppressed due to low confidence (1)
core/types/transaction.go:409
- Ensure that tx.GasFeeCap() returns a fresh instance and does not reuse an internal value, since calling Sub() modifies its receiver. If there's a risk of side effects, consider using new(big.Int).Sub(tx.GasFeeCap(), baseFee) to preserve internal state.
txGasFeeCap = txGasFeeCap.Sub(txGasFeeCap, baseFee)
zzzckck
reviewed
May 28, 2025
|
|
||
| // Get gas tip caps | ||
| txGasTipCap := tx.inner.gasTipCap() | ||
| otherGasTipCap := other.inner.gasTipCap() |
Collaborator
There was a problem hiding this comment.
approved.
here reduces 2 allocations of new(big.Int) comparing to call GasTipCap() directly.
zzzckck
approved these changes
May 28, 2025
zlacfzy
approved these changes
May 28, 2025
This was referenced May 28, 2025
Merged
This was referenced Jun 16, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize Transaction Pool Gas Tip Comparison
Description
This PR optimizes the
EffectiveGasTipCmpfunction in the transaction pool by removing an unnecessary allocation. The function compares the effective gas tips of two transactions, which is used for transaction ordering in the pool.Changes
EffectiveGasTipCmpto avoid creating newbig.IntallocationsTechnical Details
The effective gas tip is calculated as the minimum of:
The previous implementation created new
big.Intallocations throughEffectiveGasTipValue()calls. The new implementation performs the calculations directly using the existingbig.Intvalues, eliminating these allocations.Impact