miner: fix commitWork not interrupted properly#2919
Merged
zzzckck merged 1 commit intobnb-chain:developfrom Feb 27, 2025
buddh0:fix_commitwork_not_interrupt
Merged
miner: fix commitWork not interrupted properly#2919zzzckck merged 1 commit intobnb-chain:developfrom buddh0:fix_commitwork_not_interrupt
zzzckck merged 1 commit intobnb-chain:developfrom
buddh0:fix_commitwork_not_interrupt
Conversation
Contributor
Author
|
this bug exsited at least for 3 years! |
emailtovamos
approved these changes
Feb 26, 2025
zzzckck
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
miner: fix commitWork not interrupted properly
Rationale
a validator is mining block
N, but not in turn.an in turn block with Number
Narrived, so a chainHeadCh event trigged.but this validator is not allowed to mine block
N+1,in this senario, the
commitworkfor NumberNwill not be interrupted properly!Example
add an example CLI or API response...
Changes
Notable changes: