metric: revert default expensive metrics in blockchain;#2850
Merged
zzzckck merged 1 commit intobnb-chain:developfrom Jan 10, 2025
Merged
metric: revert default expensive metrics in blockchain;#2850zzzckck merged 1 commit intobnb-chain:developfrom
zzzckck merged 1 commit intobnb-chain:developfrom
Conversation
zzzckck
approved these changes
Jan 10, 2025
buddh0
reviewed
Jan 10, 2025
buddh0
approved these changes
Jan 10, 2025
This was referenced Feb 6, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will revert default expensive metrics in the blockchain. Previously the upstream code ethereum/go-ethereum#29191 has removed
--metrics.expensive, and usedNewRegisteredResettingTimerfor all time metrics. It's not suitable for BSC now, a PR #2814 reverts some metrics before, but it will cause misunderstandings about execution/validation/commit metrics(it will minus db read/commit time when enabling expensive metrics).So this PR reverts default expensive metrics and makes the blockchain time metrics work as before.
Changes
Notable changes: