Skip to content

eth: override chainconfig before create engine for testing#2822

Merged
zzzckck merged 1 commit intobnb-chain:developfrom
buddh0:override_chainconfig_timely
Dec 23, 2024
Merged

eth: override chainconfig before create engine for testing#2822
zzzckck merged 1 commit intobnb-chain:developfrom
buddh0:override_chainconfig_timely

Conversation

@buddh0
Copy link
Copy Markdown
Contributor

@buddh0 buddh0 commented Dec 23, 2024

Description

eth: override chainconfig before create engine for testing

Rationale

when create parlia engine, the signer will depend on the hardfork settings,
so override them before create engine

func LatestSigner(config *params.ChainConfig) Signer {
	var signer Signer
	if config.ChainID != nil {
		switch {
		case config.PragueTime != nil:
			signer = NewPragueSigner(config.ChainID)
		case config.CancunTime != nil:
			signer = NewCancunSigner(config.ChainID)
		case config.LondonBlock != nil:
			signer = NewLondonSigner(config.ChainID)
		case config.BerlinBlock != nil:
			signer = NewEIP2930Signer(config.ChainID)
		case config.EIP155Block != nil:
			signer = NewEIP155Signer(config.ChainID)
		default:
			signer = HomesteadSigner{}
		}
	} else {
		signer = HomesteadSigner{}
	}
	return signer
}

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 marked this pull request as ready for review December 23, 2024 06:53
@zzzckck zzzckck merged commit 2bc0a12 into bnb-chain:develop Dec 23, 2024
@buddh0 buddh0 deleted the override_chainconfig_timely branch March 3, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants