pbss: support to load legacy async buffer format#2819
Merged
zzzckck merged 8 commits intobnb-chain:developfrom Dec 25, 2024
Merged
pbss: support to load legacy async buffer format#2819zzzckck merged 8 commits intobnb-chain:developfrom
zzzckck merged 8 commits intobnb-chain:developfrom
Conversation
zzzckck
reviewed
Dec 23, 2024
Contributor
Author
|
PBSS journal history change:
The async buffer saved in the journal only changes in ver2, so we need to handle the legacy async buffer ver0/ver1 in the same way. |
buddh0
reviewed
Dec 23, 2024
zzzckck
previously approved these changes
Dec 24, 2024
NathanBSC
reviewed
Dec 24, 2024
NathanBSC
reviewed
Dec 24, 2024
buddh0
approved these changes
Dec 24, 2024
zzzckck
approved these changes
Dec 25, 2024
zzzckck
approved these changes
Dec 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a legacy journal format issue, it tries to load an async buffer in a legacy journal file.
When the PR is enabled, the node can read the async buffer correctly.
It will fix the issue #2796.
Changes
Notable changes: