fix: add blobSidecars in db inspect#2759
Merged
zzzckck merged 1 commit intobnb-chain:developfrom Nov 22, 2024
Merged
Conversation
zzzckck
approved these changes
Nov 22, 2024
galaio
approved these changes
Nov 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, in db inspect, blockBlobSidecars are treated as unaccounted data and not recognized properly.
Example error log:
t=2024-11-21T08:48:10+0000 lvl=error msg="Database contains unaccounted data" size="3.16 GiB" count=90065This issue leads to incomplete or incorrect accounting for BlobSidecars during database inspection.
Rationale
This PR updates the db inspect tool to include BlobSidecars in its statistical output, ensuring all database data is correctly accounted for.
Example
add an example CLI or API response...
Changes
Notable changes: