faucet: bump and resend faucet transaction if it has been pending for a while#2665
Merged
zzzckck merged 3 commits intobnb-chain:developfrom Aug 26, 2024
Merged
faucet: bump and resend faucet transaction if it has been pending for a while#2665zzzckck merged 3 commits intobnb-chain:developfrom
zzzckck merged 3 commits intobnb-chain:developfrom
Conversation
59ca828 to
47b77bc
Compare
one lost faucet transaction could bring down the faucet service, due to the nonce gap issue, it has to be recovered by restart the service introduce the resend logic to fix it, i.e. once the pending faucet transaction has been pending for a certain time(15seconds), resend it with a higher(bump 20%) gasPrice.
zlacfzy
previously approved these changes
Aug 26, 2024
NathanBSC
reviewed
Aug 26, 2024
MatusKysel
reviewed
Aug 26, 2024
MatusKysel
previously approved these changes
Aug 26, 2024
MatusKysel
approved these changes
Aug 26, 2024
buddh0
approved these changes
Aug 26, 2024
This was referenced Aug 27, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The faucet service is not stable, sometimes it got stuck for quite a long time and can only be recovered by restarting the process.
After some investigation, found it could be caused by transaction lost, there are various cases that a transaction can be dropped, such as network issue or discarded when TxPool is full. One lost transaction could cause the stuck of faucet service, due to the nonce gap issue.
This PR will check for each new imported block, if the faucet transaction got stuck for a certain time, trigger a resend operation, so it will not block the faucet service.
Rationale
NA
Example
NA
Changes
NA