core: not record zero hash beacon block root with Parlia engine#2621
Merged
zzzckck merged 1 commit intobnb-chain:developfrom Jul 31, 2024
Merged
Conversation
zzzckck
previously approved these changes
Jul 31, 2024
Collaborator
zzzckck
left a comment
There was a problem hiding this comment.
For BSC, beaconRoot is nil before Bohr hard fork, and empty after Bohr.
f3615b0 to
f215c44
Compare
f215c44 to
6009529
Compare
zero hash beacon block rootzero hash beacon block root with Parlia engine
zlacfzy
approved these changes
Jul 31, 2024
zzzckck
approved these changes
Jul 31, 2024
This was referenced Aug 7, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
core: not record
zero hashbeacon block rootRationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: