Skip to content

Revert "miner/worker: broadcast block immediately once sealed (bnb-chain#2576)"#2607

Merged
zzzckck merged 2 commits intobnb-chain:masterfrom
NathanBSC:for_release_v1.4.12
Jul 24, 2024
Merged

Revert "miner/worker: broadcast block immediately once sealed (bnb-chain#2576)"#2607
zzzckck merged 2 commits intobnb-chain:masterfrom
NathanBSC:for_release_v1.4.12

Conversation

@NathanBSC
Copy link
Copy Markdown
Contributor

@NathanBSC NathanBSC commented Jul 23, 2024

Description

Revert "miner/worker: broadcast block immediately once sealed (bnb-chain#2576)"

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@NathanBSC
Copy link
Copy Markdown
Contributor Author

NathanBSC commented Jul 23, 2024

rebase merge, no squash

@NathanBSC NathanBSC changed the title For release v1.4.12 Revert "miner/worker: broadcast block immediately once sealed (bnb-chain#2576)" Jul 23, 2024
Copy link
Copy Markdown
Contributor

@flywukong flywukong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzzckck zzzckck merged commit 83a9b13 into bnb-chain:master Jul 24, 2024
@NathanBSC NathanBSC deleted the for_release_v1.4.12 branch July 25, 2024 07:39
@NathanBSC
Copy link
Copy Markdown
Contributor Author

NathanBSC commented Aug 12, 2024

image
another reason: statedb.Commit may fail!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants