fix: prune-state when specify --triesInMemory 32#2602
Merged
zzzckck merged 2 commits intobnb-chain:developfrom Jul 23, 2024
Merged
fix: prune-state when specify --triesInMemory 32#2602zzzckck merged 2 commits intobnb-chain:developfrom
--triesInMemory 32#2602zzzckck merged 2 commits intobnb-chain:developfrom
Conversation
zzzckck
approved these changes
Jul 22, 2024
This was referenced Aug 7, 2024
Merged
Aces42020
approved these changes
Aug 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To address and fix the issue described in hash schema: prune state failed #2588
Rationale
The prune-state command, when specifying --triesInMemory 32, results in a "no snapshot paired state" error, while the command runs successfully with the default value.
Previously, the fixed value of TriesInMemory was set to 128 and then changed to a configurable value. However, there are still some references in the code that have not been updated. For example, during persistence in (bc *BlockChain) Stop(), the constant value 128 is still being used instead of the configurable bc.TriesInMemory().
Example
add an example CLI or API response...
Changes
Notable changes: