core: improve the network stability when double sign happens#2596
Merged
zzzckck merged 2 commits intobnb-chain:developfrom Jul 22, 2024
buddh0:double_sign_fork
Merged
core: improve the network stability when double sign happens#2596zzzckck merged 2 commits intobnb-chain:developfrom buddh0:double_sign_fork
zzzckck merged 2 commits intobnb-chain:developfrom
buddh0:double_sign_fork
Conversation
unclezoro
approved these changes
Jul 19, 2024
zzzckck
approved these changes
Jul 22, 2024
Collaborator
|
I think we can improve this expression later, to make it easier to read. |
This was referenced Aug 7, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
core: improve the network stability when double sign happens
Rationale
for example, 3 validator(vb, vc, vd) do an double sign attack together,
they can easily spilt the network into 8 subnets, then the whole chain stops
to solve this issue, we should give a definited rule to select forks.
in additon, this change is back compatible
Example
add an example CLI or API response...
Changes
Notable changes: