Skip to content

consensus/parlia: support recovery when snapshot of parlia gone in disk#2587

Merged
zzzckck merged 8 commits intobnb-chain:developfrom
buddh0:support_recovery_when_snapshot_gone
Aug 8, 2024
Merged

consensus/parlia: support recovery when snapshot of parlia gone in disk#2587
zzzckck merged 8 commits intobnb-chain:developfrom
buddh0:support_recovery_when_snapshot_gone

Conversation

@buddh0
Copy link
Copy Markdown
Contributor

@buddh0 buddh0 commented Jul 16, 2024

Description

consensus/parlia: support recovery when snapshot of parlia gone in disk

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

zlacfzy
zlacfzy previously approved these changes Jul 17, 2024
zlacfzy
zlacfzy previously approved these changes Jul 17, 2024
zlacfzy
zlacfzy previously approved these changes Jul 18, 2024
MatusKysel
MatusKysel previously approved these changes Jul 18, 2024
@buddh0 buddh0 dismissed stale reviews from MatusKysel and zlacfzy via 1c745cd July 18, 2024 05:56
zlacfzy
zlacfzy previously approved these changes Jul 18, 2024
galaio
galaio previously approved these changes Jul 18, 2024
MatusKysel
MatusKysel previously approved these changes Jul 18, 2024
@buddh0 buddh0 marked this pull request as draft July 19, 2024 05:45
@buddh0 buddh0 dismissed stale reviews from MatusKysel, galaio, and zlacfzy via 4954a0e August 5, 2024 07:18
@buddh0 buddh0 marked this pull request as ready for review August 7, 2024 10:20
@buddh0 buddh0 marked this pull request as draft August 7, 2024 11:02
@buddh0 buddh0 marked this pull request as ready for review August 7, 2024 11:31
@zzzckck
Copy link
Copy Markdown
Collaborator

zzzckck commented Aug 8, 2024

it only helps when parlia.snapshot is removed by accident, which is unlikely to happen, so it is not a big issue, but an enhancement in this corner case.

@zzzckck zzzckck merged commit e988d15 into bnb-chain:develop Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants