feat: enhance bid comparison and reply bidding results && detail logs#2538
Merged
irrun merged 14 commits intobnb-chain:developfrom Jul 11, 2024
Merged
feat: enhance bid comparison and reply bidding results && detail logs#2538irrun merged 14 commits intobnb-chain:developfrom
irrun merged 14 commits intobnb-chain:developfrom
Conversation
irrun
reviewed
Jun 25, 2024
irrun
reviewed
Jun 25, 2024
irrun
previously approved these changes
Jun 25, 2024
Contributor
|
could you please help to add a metric on bid_simulator Line547 |
irrun
previously approved these changes
Jun 25, 2024
unclezoro
suggested changes
Jun 25, 2024
Contributor
unclezoro
left a comment
There was a problem hiding this comment.
hi, We will have hot fix release soon, as this PR is not a must to have feature, so we will hold this PR after the hot fix. It may take 2 weeks.
unclezoro
reviewed
Jun 26, 2024
unclezoro
reviewed
Jun 26, 2024
unclezoro
reviewed
Jun 26, 2024
| "validatorReward", weiToEtherStringF6(bidRuntime.expectedValidatorReward), | ||
| "tx", len(newBid.bid.Txs), | ||
| "hash", newBid.bid.Hash().TerminalString(), | ||
| ) |
Contributor
There was a problem hiding this comment.
It is suggested to send a nil error back to newBid.feedback if no error happen, so that sendBid can return ASAP
Contributor
There was a problem hiding this comment.
if no error happen, it's nil.
unclezoro
reviewed
Jun 26, 2024
| delay := b.engine.Delay(b.chain, bidRuntime.env.header, &b.delayLeftOver) | ||
| if delay != nil && *delay > 0 { | ||
| bidTxsSet := mapset.NewSet[common.Hash]() | ||
| bidTxsSet := mapset.NewThreadUnsafeSetWithSize[common.Hash](len(bidRuntime.bid.Txs)) |
Contributor
There was a problem hiding this comment.
what is the motivation to change the hash set type?
Contributor
There was a problem hiding this comment.
for no concurrent operation on bidTxsSet
chore: lower report issue log level
irrun
previously approved these changes
Jul 10, 2024
zzzckck
reviewed
Jul 11, 2024
zzzckck
approved these changes
Jul 11, 2024
irrun
approved these changes
Jul 11, 2024
galaio
approved these changes
Jul 11, 2024
unclezoro
approved these changes
Jul 11, 2024
This was referenced Jul 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add builder bid arriving and comparing log into standard log output.