Skip to content

fix: waiting for the last simulation before pick best bid#2507

Merged
unclezoro merged 5 commits intobnb-chain:developfrom
irrun:i/mevfix
Jun 7, 2024
Merged

fix: waiting for the last simulation before pick best bid#2507
unclezoro merged 5 commits intobnb-chain:developfrom
irrun:i/mevfix

Conversation

@irrun
Copy link
Copy Markdown
Contributor

@irrun irrun commented Jun 6, 2024

Description

fix: waiting for the last simulation before pick best bid

Rationale

The final round of bid simulation is often interrupted by stopTimer and not fully packed, making it less competitive than local miner and degrading the mev experience.

So we take two steps to optimize it:

  1. do not set a stop timer when the bid is packaged;
  2. when the local miner fetches the best bid, wait a while for the bid that is being packaged at the time to finish job.

This is a short-term solution. It will be addressed in the long run with a more formal fix and be put into the next stable release.

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@unclezoro unclezoro merged commit af7e9b9 into bnb-chain:develop Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants