fix: waiting for the last simulation before pick best bid#2507
Merged
unclezoro merged 5 commits intobnb-chain:developfrom Jun 7, 2024
irrun:i/mevfix
Merged
fix: waiting for the last simulation before pick best bid#2507unclezoro merged 5 commits intobnb-chain:developfrom irrun:i/mevfix
unclezoro merged 5 commits intobnb-chain:developfrom
irrun:i/mevfix
Conversation
unclezoro
reviewed
Jun 6, 2024
unclezoro
reviewed
Jun 6, 2024
unclezoro
reviewed
Jun 6, 2024
unclezoro
reviewed
Jun 6, 2024
unclezoro
reviewed
Jun 6, 2024
unclezoro
approved these changes
Jun 7, 2024
zzzckck
approved these changes
Jun 7, 2024
This was referenced Jun 11, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: waiting for the last simulation before pick best bid
Rationale
The final round of bid simulation is often interrupted by stopTimer and not fully packed, making it less competitive than local miner and degrading the mev experience.
So we take two steps to optimize it:
This is a short-term solution. It will be addressed in the long run with a more formal fix and be put into the next stable release.
Example
add an example CLI or API response...
Changes
Notable changes: