BEP-402: Complete Missing Fields in Block Header to Generate Signature#2502
Merged
zzzckck merged 1 commit intobnb-chain:developfrom Jul 19, 2024
buddh0:fix_SealSig
Merged
BEP-402: Complete Missing Fields in Block Header to Generate Signature#2502zzzckck merged 1 commit intobnb-chain:developfrom buddh0:fix_SealSig
zzzckck merged 1 commit intobnb-chain:developfrom
buddh0:fix_SealSig
Conversation
galaio
previously approved these changes
Jun 5, 2024
Collaborator
|
need a BEP for this PR. |
zzzckck
requested changes
Jul 3, 2024
Collaborator
zzzckck
left a comment
There was a problem hiding this comment.
Will not merge until the BEP-402 is fully accepted.
pythonberg1997
approved these changes
Jul 3, 2024
Contributor
Author
|
rebase develop 07.11 |
zzzckck
approved these changes
Jul 19, 2024
Collaborator
With a second thought, it is ok to merge it. We can just not enable it, if the community reject this BEP. |
This was referenced Aug 7, 2024
Merged
monkeydluffyto
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BEP-402: Complete Missing Fields in Block Header to Generate Signature
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: