internal/ethapi: add optional parameter for blobSidecars#2467
Merged
zzzckck merged 4 commits intobnb-chain:developfrom May 16, 2024
Merged
internal/ethapi: add optional parameter for blobSidecars#2467zzzckck merged 4 commits intobnb-chain:developfrom
zzzckck merged 4 commits intobnb-chain:developfrom
Conversation
NathanBSC
reviewed
May 16, 2024
buddh0
approved these changes
May 16, 2024
zzzckck
approved these changes
May 16, 2024
This was referenced Jun 11, 2024
Merged
Zionsammy
reviewed
Jun 14, 2024
Zionsammy
left a comment
There was a problem hiding this comment.
contracts/helpers/VerifierCaller.sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the param showBlob optional, user don't need change the way to query blobs, even if they don't add the bool param it work as before.
Rationale
tell us why we need these changes...
Example
The two way both works now.
Changes
Notable changes: