Skip to content

core: clearup feynman testflag and rialto code#2457

Merged
zzzckck merged 1 commit intobnb-chain:developfrom
NathanBSC:clear_feynman_testflag_rialtocode
May 14, 2024
Merged

core: clearup feynman testflag and rialto code#2457
zzzckck merged 1 commit intobnb-chain:developfrom
NathanBSC:clear_feynman_testflag_rialtocode

Conversation

@NathanBSC
Copy link
Copy Markdown
Contributor

Description

core: clearup feynman testflag and rialto code

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 requested review from galaio and jingjunLi May 14, 2024 07:14
enc.StateHistory = c.StateHistory
enc.StateScheme = c.StateScheme
enc.PathSyncFlush = c.PathSyncFlush
enc.JournalFileEnabled = c.JournalFileEnabled
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jingjunLi
after add new field to ethconfig, gen_config.go should be regenerated

Copy link
Copy Markdown
Contributor

@galaio galaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzzckck zzzckck merged commit 0560685 into bnb-chain:develop May 14, 2024
@NathanBSC NathanBSC deleted the clear_feynman_testflag_rialtocode branch July 25, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants