fix: trieJournal format compatible old db format#2395
Merged
zzzckck merged 4 commits intobnb-chain:developfrom Apr 16, 2024
Merged
fix: trieJournal format compatible old db format#2395zzzckck merged 4 commits intobnb-chain:developfrom
zzzckck merged 4 commits intobnb-chain:developfrom
Conversation
Contributor
|
can we avoid to change the interface of function loadDiffLayer, loadDiskLayer and journal? |
Contributor
|
why a field |
Contributor
Author
We can avoid changing the interface of functions loadDiffLayer and loadDiskLayer. However, the journal is called by diffLayer and diskLayer, which cannot access db.config.JournalFilePath. |
NathanBSC
approved these changes
Apr 16, 2024
buddh0
approved these changes
Apr 16, 2024
zzzckck
approved these changes
Apr 16, 2024
This was referenced Apr 26, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If trieJournal is stored in the database, it retains the old journal format; if trieJournal writes to the journal file using the new journal format;
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: