fix: print value instead of pointer in ConfigCompatError#2391
Merged
zzzckck merged 1 commit intobnb-chain:developfrom Apr 15, 2024
buddh0:fix_print_ConfigCompatError
Merged
fix: print value instead of pointer in ConfigCompatError#2391zzzckck merged 1 commit intobnb-chain:developfrom buddh0:fix_print_ConfigCompatError
zzzckck merged 1 commit intobnb-chain:developfrom
buddh0:fix_print_ConfigCompatError
Conversation
zzzckck
approved these changes
Apr 12, 2024
blxdyx
approved these changes
Apr 15, 2024
zlacfzy
approved these changes
Apr 15, 2024
This was referenced Apr 26, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: print value instead of pointer in ConfigCompatError
Rationale
two errors in func ConfigCompatError as error info in the above picture
RewindToTime overflow
for dev testnet, often set timebased hardfork to
0, so they will be enabled same with London Block at genesisfor example in genesis.json
"shanghaiTime": 0,then we change it
"shanghaiTime": 1712889032,and run `geth --datadir ./ init ./genesis.json, then RewindToTime will overflow to the max of uint64 type
err.StoredTime and err.NewTime are pointers, print them is meaningless, their value are desired
Example
add an example CLI or API response...
Changes
Notable changes: