feat: add bid fee ceil in mev_params#2357
Merged
irrun merged 3 commits intobnb-chain:developfrom Apr 1, 2024
irrun:re/bidfeeceil
Merged
feat: add bid fee ceil in mev_params#2357irrun merged 3 commits intobnb-chain:developfrom irrun:re/bidfeeceil
irrun merged 3 commits intobnb-chain:developfrom
irrun:re/bidfeeceil
Conversation
unclezoro
approved these changes
Apr 1, 2024
unclezoro
reviewed
Apr 1, 2024
miner/miner_mev.go
Outdated
|
|
||
| type MevConfig struct { | ||
| Enabled bool // Whether to enable Mev or not | ||
| BidFeeCeil uint64 // The maximum builder fee of a bid |
Contributor
There was a problem hiding this comment.
uint64 is not enough, it should be big.Int
unclezoro
suggested changes
Apr 1, 2024
Contributor
unclezoro
left a comment
There was a problem hiding this comment.
please fix the comment
unclezoro
approved these changes
Apr 1, 2024
forcodedancing
approved these changes
Apr 1, 2024
pythonberg1997
approved these changes
Apr 1, 2024
This was referenced Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
feat: add bid fee ceil in mev_params